lnd: label the tx to make it easier to audit #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YusukeShimizu
force-pushed
the
label-transaction
branch
4 times, most recently
from
197c802 to
b07c2b3
Compare
Ensure that all lnd transactions related to peerswaps are identifiable by the label `peerswap`. This makes it easier to audit the transactions from faraday. This is performed by LND's LabelTransaction RPC. Since CLN has no such function, no label is assigned. Since label recording is not an essential requirement for swap, if it fails, it is logged and subsequent processing is continued.
YusukeShimizu
force-pushed
the
label-transaction
branch
from
b07c2b3 to
eea02b3
Compare
mrfelton
reviewed
Feb 12, 2024
Comment on lines
+220
to
+223
| &walletrpc.LabelTransactionRequest{ | ||
| Txid: txIDHash.CloneBytes(), | ||
| Label: label, | ||
| Overwrite: true}) |
There was a problem hiding this comment.
I think we should include a reference to the swap that the transaction relates to in the label. e.g. the swap id, or first few characters of swap id (this is what Lightning Loop does, I think just to keep the labels shorter and more readable)
Here are some examples of the onchain transaction labels added by Loop:
loopd -- OutSweepSuccess(swap=40f86b)
loopd -- InHtlc(swap=e5145f)
loopd -- InSweepTimeout(swap=3cc561)
There was a problem hiding this comment.
With reference to loopd, the following labels are set.
peerswap -- Opening(swap id=b171ee)peerswap -- ClaimByCoop(swap id=b171ee)peerswap -- ClaimByCsv(swap id=b171ee)peerswap -- ClaimByInvoice(swap id=b171ee)
Merged
YusukeShimizu
force-pushed
the
label-transaction
branch
from
ba1fd4e to
19f7060
Compare
Add labels package to handle labeling on-chain transactions. * Opening label * claim by CSV label * claim by cooperative close label
YusukeShimizu
force-pushed
the
label-transaction
branch
from
19f7060 to
22c7144
Compare
|
I initiated a swapout and the unconfirmed onchain transaction got it's label applied. This is the transaction from the node initiating the swapout (lnd1): {
"tx_hash": "bf66241fd8c55aa7024b762289660d10ad1bc615f60132e2cd62c43c712db4ec",
"amount": "992000",
"num_confirmations": 0,
"block_hash": "",
"block_height": 0,
"time_stamp": "1707997184",
"total_fees": "0",
"dest_addresses": [
"bcrt1qll65rvr3ggvzz50sen6xvw99spmrztgywvzzau"
],
"output_details": [
{
"output_type": "SCRIPT_TYPE_WITNESS_V0_PUBKEY_HASH",
"address": "bcrt1qll65rvr3ggvzz50sen6xvw99spmrztgywvzzau",
"pk_script": "0014fff541b07142182151f0ccf46638a58076312d04",
"output_index": "0",
"amount": "992000",
"is_our_address": true
}
],
"raw_tx_hex": "02000000000101dad897bb530ecc0fe26fe6aacab4845ffd64a02479671432d19dd4493c28a5a50000000000000000000100230f0000000000160014fff541b07142182151f0ccf46638a58076312d04054730440220250226405fae6d453324b16877a4c7ad37c06248342f0e588238848ee84d0d0f02201373210c9803a1332c78f2db15ae71484c4d755300cfc93df93d5fc8e09ab73e01208a3a831e09bebeb970701575505e13db0d5caf924460b7ee3e26acd1f7c911ca0000992103e5389980897a881f233fcde840a9d370a04441d8fa5767fcc98c959e64840947ac642103e5389980897a881f233fcde840a9d370a04441d8fa5767fcc98c959e64840947ac6482012088a820ed18813b1a45fd636987d733faacc1f323be169fbff8e75b1db5b478d7b6a83588682103162589014005b0ecb17200b027687d07b12f94e1f2ef5d56b37df68dc6888060ac6702f003b26800000000",
"label": "peerswap -- ClaimByInvoice(swap id=ecaf24)",
"previous_outpoints": [
{
"outpoint": "a5a5283c49d49dd13214677924a064fd5f84b4caaae66fe20fcc0e53bb97d8da:0",
"is_our_output": false
}
]
}And on the other node (lnd2): {
"tx_hash": "a5a5283c49d49dd13214677924a064fd5f84b4caaae66fe20fcc0e53bb97d8da",
"amount": "-1007650",
"num_confirmations": 6,
"block_hash": "0c859654bb9a9c3413fcef8cf9b11fc442d697550c216b5f6fe6eabe77518df2",
"block_height": 116,
"time_stamp": "1707997172",
"total_fees": "7650",
"dest_addresses": [
"bcrt1quyukzat3zrzuqhvt2accxkkt6ccz0u8j74h0azxqh5yur59yqhfsqd7ygs",
"bcrt1q0eh929jvkxazzajttpn3x47zt8wqzyratckfek"
],
"output_details": [
{
"output_type": "SCRIPT_TYPE_WITNESS_V0_SCRIPT_HASH",
"address": "bcrt1quyukzat3zrzuqhvt2accxkkt6ccz0u8j74h0azxqh5yur59yqhfsqd7ygs",
"pk_script": "0020e13961757110c5c05d8b5771835acbd63027f0f2f56efe88c0bd09c1d0a405d3",
"output_index": "0",
"amount": "1000000",
"is_our_address": false
},
{
"output_type": "SCRIPT_TYPE_WITNESS_V0_PUBKEY_HASH",
"address": "bcrt1q0eh929jvkxazzajttpn3x47zt8wqzyratckfek",
"pk_script": "00147e6e55164cb1ba21764b58671357c259dc01107d",
"output_index": "1",
"amount": "98992350",
"is_our_address": true
}
],
"raw_tx_hex": "02000000000101e4ccaec69876d955e9f208ffb7d82e8c4bfe1b67da654587290641495ae2103f0200000000ffffffff0240420f0000000000220020e13961757110c5c05d8b5771835acbd63027f0f2f56efe88c0bd09c1d0a405d3de80e605000000001600147e6e55164cb1ba21764b58671357c259dc01107d0247304402205612f6d8d8c4a6a5cca015cee93b52b3714d43cec99ec78616cc6d58c8d84d1b02201bfcacc440cb0b0e35d0d606b8fd1ae356f2c45d46807cab3e89bf388835abd5012102747f4287846b4bf545cc91282c6b69dd4ca7c37a4e5080cb48db37451e14046500000000",
"label": "peerswap -- Opening(swap id=ecaf24)",
"previous_outpoints": [
{
"outpoint": "3f10e25a49410629874565da671bfe4b8c2ed8b7ff08f2e955d97698c6aecce4:2",
"is_our_output": true
}
]
}However I also get these following errors in the logs for the initiating node (lnd1)
|
Receiving nodes should not attempt to apply a label to this transaction that is not being tracked by the receiving node
YusukeShimizu
force-pushed
the
label-transaction
branch
from
143f487 to
2ce98c1
Compare
|
Receiving node label operation removed. |
|
Tested as working on lnd. |
mrfelton
approved these changes
Feb 15, 2024
|
Looks good to me, thanks @YusukeShimizu! ACK 2ce98c1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all lnd transactions related to peerswaps are identifiable by the label
peerswap.This makes it easier to audit the transactions from faraday.
This is performed by LND's LabelTransaction RPC.
If it fails, it is logged and subsequent processing is continued.
#254.
Samples are shown below.
peerswap -- Opening(swap id=b171ee)peerswap -- ClaimByCoop(swap id=b171ee)peerswap -- ClaimByCsv(swap id=b171ee)peerswap -- ClaimByInvoice(swap id=b171ee)